Use warning also in abs_time_to_prev_next_interval

[dachengx]

What is the problem / what does the code in this PR do

Sometimes things in abs_time_to_prev_next_interval might be overlapping, or the endtime might be not sorted. So throw warning instead of error, following the logic of touching_windows.

Can you briefly describe how it works?

Just change the warning logic, the algorithm is not changed.

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

• Update the docstring(s)
• Update the documentation
• Tests to check the (new) code is working as desired.
• Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

[dachengx]

If my understanding is correct, the abs_time_to_prev_next_interval will return a valid result if endtime of things are sorted, but not things are not overlapping.

[coveralls]

coverage: 91.546% (-0.05%) from 91.591% when pulling b66172b on abs_time_to_prev_next_interval_warning into bf0c16b on master.

[FaroutYLq]

Looks good to me. How often do you expect this warning be triggered? I won't delete log files for this round of reprocessing so we can trace back anywise

[dachengx]

Looks good to me. How often do you expect this warning be triggered? I won't delete log files for this round of reprocessing so we can trace back anywise

For this function, I think you will not see warnings in straxen's plugins(because it is only used on the event level in straxen). But in some customized plugins outside strax(en), it is better to print out the warnings rather than errors just like touching_windows and split_by_containments.

[FaroutYLq]

For this function, I think you will not see warnings in straxen's plugins(because it is only used on the event level in straxen).

Sorry I am confused, why I won't see these warning? For reprocessing we goes up to events

[dachengx]

Sorry I am confused, why I won't see these warning? For reprocessing we goes up to events

Events in straxen are not overlapping so that they will not trigger warnings.

[dachengx]

Events in straxen are not overlapping so that they will not trigger warnings.

So this PR is almost only for the users applying the function to their own data where the things might be overlapping.

[FaroutYLq]

Events in straxen are not overlapping so that they will not trigger warnings.

Wait then I think I need to reevaluate this PR: if this abs_time_to_prev_next_interval is only used in event level, and in event level we don't expect any overlap, should we keep the original assertion back there?

[dachengx]

Wait then I think I need to reevaluate this PR: if this abs_time_to_prev_next_interval is only used in event level, and in event level we don't expect any overlap, should we keep the original assertion back there?

abs_time_to_prev_next_interval is used in straxen event level. But it can also be applied to other levels or other data, outside straxen. strax is an independent package from any specified TPC so we would allow users to apply it to any kind of data?

[FaroutYLq]

abs_time_to_prev_next_interval is used in straxen event level. But it can also be applied to other levels or other data, outside straxen. strax is an independent package from any specified TPC so we would allow users to apply it to any kind of data?

It is true that strax is an independent package... Then should we add no-overlap assertion, correspondingly in straxen where abs_time_to_prev_next_interval is applied?

[dachengx]

Wait then I think I need to reevaluate this PR: if this abs_time_to_prev_next_interval is only used in event level, and in event level we don't expect any overlap, should we keep the original assertion back there?

If we want to test that the events are not overlapping in straxen, we should do it in straxen's Event plugin.

[WenzDaniel]

Hej guys thanks. The only place we are using this function at the moment is the deadtime calculation in cutax. And here I think nothing can overlap (I hope at least).

[FaroutYLq]

Hi @WenzDaniel are you sure? I didn't find anything in cutax using this function, but I do find only one in straxen here