Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split compare_metadata into utils.compare_meta #754

Merged
merged 3 commits into from Aug 30, 2023

Conversation

dachengx
Copy link
Collaborator

What is the problem / what does the code in this PR do

Split compare_metadata into utils.compare_dict, to use utils.compare_dict somewhere else.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@dachengx dachengx merged commit a466a94 into master Aug 30, 2023
10 checks passed
@dachengx dachengx deleted the split_compare_metadata branch August 30, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant