Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to v1.6.0, drop py3.8 #792

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Bump to v1.6.0, drop py3.8 #792

merged 8 commits into from
Jan 16, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Jan 15, 2024

Bump minor version because we dropped py3.8

@dachengx dachengx marked this pull request as ready for review January 15, 2024 08:48
@dachengx dachengx changed the title Bump to v1.5.6, use trusted publisher Bump to v1.5.6 Jan 16, 2024
@coveralls
Copy link

coveralls commented Jan 16, 2024

Coverage Status

coverage: 91.433% (+0.05%) from 91.388%
when pulling dda2f26 on bump_v156
into 882a8bf on master.

@dachengx dachengx changed the title Bump to v1.5.6 Bump to v1.5.6, drop py3.8 Jan 16, 2024
@dachengx dachengx changed the title Bump to v1.5.6, drop py3.8 Bump to v1.6.0, drop py3.8 Jan 16, 2024
@WenzDaniel
Copy link
Collaborator

I think we had this numerical error before:

 aftobs = 3.469446951953614e-18, aft = 0.125, s1tot = 2.652351386976591

    @settings(deadline=None)
    @given(strategies.floats(0.0, 1.0), strategies.floats(0.01, 0.99), strategies.floats(2.0, 1000))
    def test_patternfit_stats(aftobs, aft, s1tot):
        s1top = aftobs * s1tot
>       assert (binom_test(s1top, s1tot, aft) >= 0) & (binom_test(s1top, s1tot, aft) <= 1)
E       assert (1.0000000000000002 >= 0 & 1.0000000000000002 <= 1)
E        +  where 1.0000000000000002 = binom_test(9.202192435055875e-18, 2.652351386976591, 0.125)
E        +  and   1.0000000000000002 = binom_test(9.202192435055875e-18, 2.652351386976591, 0.125)
E       Falsifying example: test_patternfit_stats(
E           aftobs=3.469446951953614e-18,
E           aft=0.125,
E           s1tot=2.652351386976591,
E       )
E       
E       You can reproduce this example by temporarily adding @reproduce_failure('6.93.1', b'AXicY2BgODyBAQYOKMCZDSKcnCyMDE8BPbIDxA==') as a decorator on your test case

We should try to address it and make the requirements maybe less tight. However, no show stopper.

@WenzDaniel WenzDaniel merged commit 2e4c48a into master Jan 16, 2024
8 checks passed
@dachengx dachengx deleted the bump_v156 branch January 16, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants