fix negative drift time

[XeBoris]

Simple main s1/s2 pairing: The main s1 (largest s1) have to be before main s2 (largest s2)

[tunnell]

Small things just worth knowing

[tunnell]

Can replace with:

from collections import defaultdict
s2_info = defaultdict(None)

[tunnell]

Can combine with above liine

[JelleAalbers]

Thanks! Here is a suggestion which finds a different main S1 (which might work, I don't know :-) ):

        main_s = dict()
        # Note S2 must be first, see below
        for s_i in [2, 1]:
            s_mask = peaks['type'] == s_i

            # For determining the main S1, remove all peaks
            # after the main S2 (if there was one)
            # This is why S2 finding happened first
            if s_i == 1 and result[f's2_index'] != -1:
                s_mask &= peaks['time'] > main_s[2]['time']

            ss = peaks[s_mask]

Maybe at some time adding a max drift time option and another &= mask changing to avoid matching to S1s outside the max drift time would be useful

[JelleAalbers]

Thanks Boris! This will deal with the negative drift times.

[JelleAalbers]

Ok, you mean: only compute the drift time if we identified a valid s1-s2 pair.