Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strax.plugin #825

Merged
merged 1 commit into from Apr 22, 2024
Merged

Remove strax.plugin #825

merged 1 commit into from Apr 22, 2024

Conversation

dachengx
Copy link
Collaborator

What is the problem / what does the code in this PR do

Previously, strax.plugin.CutPlugin or from strax.plugin import CutPlugin will cause error:

>>> strax.plugin.CutPlugin
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'strax.plugins.plugin' has no attribute 'CutPlugin'
>>> from strax.plugin import CutPlugin
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/xudc/strax/strax/plugin.py", line 2, in <module>
    from plugins import (
ModuleNotFoundError: No module named 'plugins'

This means that strax/plugin.py is never properly used., so we delete them.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@dachengx dachengx requested a review from yuema137 April 20, 2024 11:56
@coveralls
Copy link

coveralls commented Apr 20, 2024

Coverage Status

coverage: 91.538% (+0.03%) from 91.504%
when pulling 1e7205f on rm_plugin
into 4305e99 on master.

@dachengx dachengx marked this pull request as ready for review April 20, 2024 12:10
@dachengx dachengx merged commit 67a7831 into master Apr 22, 2024
9 checks passed
@dachengx dachengx deleted the rm_plugin branch April 22, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants