Rethrow exceptions #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunnell
approved these changes
Aug 31, 2018
| e_args = '' | ||
| self.kill(reason=f"{e.__class__.__name__}('{e_args}') " | ||
| f'in {threading.current_thread().name}') | ||
| self.kill(reason=(e.__class__, e, sys.exc_info()[2])) |
There was a problem hiding this comment.
If I add variables to the exception (e.key), will that get propogated out?
There was a problem hiding this comment.
Yes, it reraises the original object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes exception handling in the mailbox and processor systems so the original exception, rather than MailboxKilled, is thrown to the user.
This also adds a test to ensure the correct original exception is stored in the metadata; and changes the warning on loading data with no chunks to an error (new custom exception class DataCorrupted).