Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions when loading corrupted data #88

Merged
merged 8 commits into from Sep 2, 2018

Conversation

JelleAalbers
Copy link
Member

@JelleAalbers JelleAalbers commented Aug 31, 2018

This improves strax' behaviour under exceptional conditions:

  • Raise DataCorrupted when attempting to load data which has not been completely written, or whose writing terminated with an exception. This check is skipped only for metadata loading, so we can still inspect the exception that corrupted the data. (thanks @feigaodm for demonstrating how necessary this exception is)
  • Raise a more informative exception when a user attempt to load data with array_fields through get_df (thanks @coderdj)
  • Remove unused code for handling exceptions on ambiguous data requests (which can occur with fuzzy data matching). None of the backends actually supported this. Ambiguous requests will continue to simply return the first match. Note such requests are only possible if the user sets fuzzy matching options.
  • Bugfix for fuzzy matching in the files backend (wrong directory name returned). I added a test to catch this in the future.

@JelleAalbers JelleAalbers merged commit 59e755e into AxFoundation:master Sep 2, 2018
@JelleAalbers JelleAalbers deleted the corrupted_check branch September 2, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants