Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Client] Fix style and code of Accordion #456

Open
GuillaumeKESTEMAN opened this issue Aug 7, 2024 · 0 comments · May be fixed by #459
Open

[Client] Fix style and code of Accordion #456

GuillaumeKESTEMAN opened this issue Aug 7, 2024 · 0 comments · May be fixed by #459
Assignees
@GuillaumeKESTEMAN
Labels
component component needs to be worked on css-package Affects the CSS package look'n feel

Comments

@GuillaumeKESTEMAN
Copy link
Contributor

GuillaumeKESTEMAN commented Aug 7, 2024 •
edited
Loading

Des problèmes de styles sont visibles sur le composant Accordion sur le design-system, voici ceux relevés :

  • Problème de séparateur qui doit être fullwidth
  • Pour le titre on doit pouvoir mettre du jsx et non seulement une string
  • Vérifier l'espacement
    Il y a peut-être d'autres problèmes de style mais tous n'ont pas été relevés.

356529570-5d8b648d-1716-49f4-b750-3c2547635089

De plus l'architecture HTML n'est pas correcte car pour le moment on gère l'accordion avec des div et un bouton.
Il faut utiliser les balises details et summary

Figma : https://www.figma.com/design/21801ytpBZM2hBkaxGdzgW/01.-Composants-Espace-Client?node-id=1028-37126&t=l27HotPsNG3qwwFC-4

image
@GuillaumeKESTEMAN GuillaumeKESTEMAN added css-package Affects the CSS package look'n feel labels Aug 7, 2024
@GuillaumeKESTEMAN GuillaumeKESTEMAN self-assigned this Aug 7, 2024
@GuillaumeKESTEMAN GuillaumeKESTEMAN changed the title [Client] Fix style of Accordion [Client] Fix style and code of Accordion Aug 9, 2024
@GuillaumeKESTEMAN GuillaumeKESTEMAN added the component component needs to be worked on label Aug 9, 2024
@GuillaumeKESTEMAN GuillaumeKESTEMAN linked a pull request Aug 9, 2024 that will close this issue
Draft
@GuillaumeKESTEMAN GuillaumeKESTEMAN linked a pull request Aug 9, 2024 that will close this issue
Fix(client): Accordion #459
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeKESTEMAN GuillaumeKESTEMAN

Labels
component component needs to be worked on css-package Affects the CSS package look'n feel
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix(client): Accordion GuillaumeKESTEMAN/design-system
1 participant
@GuillaumeKESTEMAN