feature/summary-component #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triki-Ahmed
force-pushed
the
component-summary
branch
from
dcd7a61
to
03659de
Compare
D'après ce que j'ai vu sur le toolkit non , ce composant utilise le composant Alert. |
GuillaumeKESTEMAN
previously approved these changes
Apr 25, 2024
Comment on lines
+33
to
+39
| {messages.map((message) => { | ||
| return ( | ||
| <li className="af-summary__message-item" key={`message_${message}`}> | ||
| {message} | ||
| </li> | ||
| ); | ||
| })} |
There was a problem hiding this comment.
Suggested change
| {messages.map((message) => { | |
| return ( | |
| <li className="af-summary__message-item" key={`message_${message}`}> | |
| {message} | |
| </li> | |
| ); | |
| })} | |
| {messages.map((message) => ( | |
| <li className="af-summary__message-item" key={`message_${message}`}> | |
| {message} | |
| </li> | |
| ))} |
pplancq
previously approved these changes
May 15, 2024
Triki-Ahmed
dismissed stale reviews from pplancq and GuillaumeKESTEMAN
via
6141edc
Triki-Ahmed
force-pushed
the
component-summary
branch
from
03659de
to
6141edc
Compare
pplancq
approved these changes
May 16, 2024
| @@ -12,6 +12,7 @@ export { | |||
| CheckboxModes, | |||
| } from "./Form/Checkbox/Agent"; | |||
| export { Choice, ChoiceInput } from "./Form/Choice"; | |||
| export { Summary } from "./Summary/Summary"; | |||
There was a problem hiding this comment.
il faudrait peut-être créer un ./Summary/index.ts afin d'importer en faisant "./Summary" (comme pour les autres composants).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29
Expose a component just like the https://axafrance.github.io/react-toolkit/latest/storybook/index.html?path=/story/form-elements-summary--summary-story