Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State is not valid in Safari #1079

Closed
JakubKacik opened this issue Jun 30, 2023 · 11 comments
Closed

State is not valid in Safari #1079

JakubKacik opened this issue Jun 30, 2023 · 11 comments

Comments

@JakubKacik
Copy link

Issue and Steps to Reproduce

There is an issue with a very short timeout to perform login action in Safari. When login actions takes approximately more than 30 sec then invalid state error is occurring.

In Chrome there is no problem.

It is reproducible also in demo app with default settings.

  1. Click to Login
  2. Redirect to Identity Server
  3. Wait some time and then Login
  4. After redirection back to client there is an error

Versions

react-oidc: 6.23.0
Safari: 16.3

Screenshots

Screenshot 2023-06-30 at 14 07 11

Expected

Successful redirect to client application

Actual

Screenshot 2023-06-30 at 14 02 39
@guillaume-chervet
Copy link
Contributor

Hi @JakubKacik , thank you for your issue.
Do you have a sample of your configuration?

@JakubKacik
Copy link
Author

Hi @guillaume-chervet. It is default configuration for demo react project in you package.

Screenshot 2023-06-30 at 21 31 38

@guillaume-chervet
Copy link
Contributor

Thank you @JakubKacik i need to analyse to find the best solution.
Do you need service worker mode? I can disable it temporary on safari. The time to find solution.

@JakubKacik
Copy link
Author

I think that I am able to use it without service worker until you will find the solution.

Thank you.

@guillaume-chervet
Copy link
Contributor

hi @JakubKacik ,

I think I have resolve it int the PullRequest #1084 .

Does the demo work for you on iOS? https://black-rock-0dc6b0d03-1084.westeurope.1.azurestaticapps.net/

@JakubKacik
Copy link
Author

Hi @guillaume-chervet,

unfortunately, there is another authentication error.

Screenshot 2023-07-09 at 16 36 19

@guillaume-chervet
Copy link
Contributor

Thank you @JakubKacik for the feedback. I may need to affine the pullrequest :p

@guillaume-chervet
Copy link
Contributor

hi @JakubKacik ,

Do you still have the problem on the lastest demo from the PullRequest?
https://black-rock-0dc6b0d03-1084.westeurope.1.azurestaticapps.net/

@JakubKacik
Copy link
Author

Hi @guillaume-chervet,

Now it is working as expected, thank you. I tried it with 1 minute redirect delay and authentication was successful.

@guillaume-chervet
Copy link
Contributor

Thank you @JakubKacik.
Lastest fixed version is published.

@guillaume-chervet
Copy link
Contributor

I close the issue @JakubKacik. Feel free to reopen it if needed.
And again thank you very much for your issue !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants