fix(router) : Add some polyfills for IE #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youf-olivier
force-pushed
the
fix/oidcRouter
branch
from
a754b1f
to
970b000
Compare
guillaumechervetaxa
previously approved these changes
Oct 8, 2019
|
I have to add some tests before merging the PR |
youf-olivier
force-pushed
the
fix/oidcRouter
branch
from
970b000
to
5bdbd3c
Compare
youf-olivier
force-pushed
the
fix/oidcRouter
branch
from
5bdbd3c
to
087e721
Compare
guillaumechervetaxa
approved these changes
Oct 8, 2019
|
Cool :) But I ask myself one question, what if the project includes the polyfill itself ? Shouldn't be this optional ? |
|
I Just add the polyfill in the sample and the doc, so the project HAVE TO include polyfill. Just for the event in the router, because it is not a simple polyfill. |
romuleald
reviewed
Oct 9, 2019
| @@ -1,4 +1,6 @@ | |||
| import React from 'react'; | |||
| import './ie.polyfills'; | |||
There was a problem hiding this comment.
Ce n'est pas aux projets de gérer leurs compatibilités ? En faisant ça tu forcerais une webapp à avoir du code pour IE inutilement
There was a problem hiding this comment.
C'est dans le sample ;) donc pas dans le package final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #312