refactor(TitleBar) : Add Left Title Property to TitleBar #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code-wise, it's ok for me.
But for design on the storybook there are things that bother me :
-
In the default TitleBar story the arrow is not completely aligned with the text :
https://www.chromatic.com/test?appId=617bf762e2c8d7003a0d5c15&id=664202423a7549bea7be19dd -
In the complex TitleBar story the right elements are no longer on the far right but just to the right of the title and the title is not completely vertically centered
https://www.chromatic.com/test?appId=617bf762e2c8d7003a0d5c15&id=664202423a7549bea7be19de
Were these changes planned?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1186