Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add props to footer component to hide icon #120

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

barry-thierno
Copy link
Contributor

Related issue

#77

Reference to the issue

Here you can add link to related issue
Logo link in the footer #77

Description of the issue

Your description

Person(s) for reviewing proposed changes

You can add @mention here

Important

Before creating a pull request run unit tests

$ npm test

# watch for changes
$ npm test -- --watch

# For a specific file (e.g., in packages/context/__tests__/command.test.js)
$ npm test -- --watch packages/action

@barry-thierno
Copy link
Contributor Author

@johnmeunier here is a proposition for enhancement you create about footer component.
Thank for you validation.

@samuel-gomez-axa
Copy link
Contributor

samuel-gomez-axa commented Mar 25, 2019

Hello @barry-thierno , thanks for your contribution :)

In issue #77 , @johnmeunier wanted to make optional logo link by a new property.
You had a new property to do this: isIconHidden

I would prefer to use the icon accessories to show / hide the logo and use the href accessories to show / hide the logo link. I think is more flexible

What do you think ?

@barry-thierno
Copy link
Contributor Author

I'm agree with your proposition

@youf-olivier
Copy link
Contributor

Any Update for this PR ?

@guillaumechervetaxa
Copy link
Contributor

Hi @barry-thierno, any Update for this PR ?

@barry-thierno barry-thierno force-pushed the feature/Make_Footer_Logo_Link_Hidden branch from 13c53e2 to 1a6a203 Compare July 22, 2020 12:50
@barry-thierno barry-thierno force-pushed the feature/Make_Footer_Logo_Link_Hidden branch from 24b2922 to db3f2f9 Compare July 22, 2020 14:42
@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@mergify mergify bot merged commit 2d52901 into master Jul 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/Make_Footer_Logo_Link_Hidden branch July 23, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants