feat: design for file input #305 #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korger-johan
reviewed
Jul 5, 2019
korger-johan
suggested changes
Jul 5, 2019
There was a problem hiding this comment.
Finally, a nice design to input file.
Thanks @samuel-gomez-axa
samuel-gomez-axa
requested review from
korger-johan
and removed request for
youf-olivier and
guillaumechervetaxa
samuel-gomez-axa
added
Type: Bug
korger-johan
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#305
Reference to the issue
#305
Description of the issue
Design for file inputPerson(s) for reviewing proposed changes
@guillaumechervet , @youf-olivier