Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: omit props and display errors #309

Merged
merged 1 commit into from
Jul 10, 2019
Merged

fix: omit props and display errors #309

merged 1 commit into from
Jul 10, 2019

Conversation

samuel-gomez-axa
Copy link
Contributor

  • Warning properties on DOM Element input file
  • Errors input doesn't display if no values

guillaumechervetaxa
guillaumechervetaxa approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@guillaumechervetaxa guillaumechervetaxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Samuel :)

@mergify mergify bot merged commit 83bdd30 into master Jul 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/file-input branch July 10, 2019 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumechervetaxa guillaumechervetaxa guillaumechervetaxa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuel-gomez-axa @guillaumechervetaxa