Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicated files #395

Merged
merged 1 commit into from
Oct 3, 2019
Merged

fix: remove duplicated files #395

merged 1 commit into from
Oct 3, 2019

Conversation

xballoy
Copy link
Contributor

@xballoy xballoy commented Oct 1, 2019

Description of the issue

When doing a git checkout of the project we have the following warning

warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'storybook/design-system/src/components/colors/Color.pug'
  'storybook/design-system/src/components/colors/color.pug'
  'storybook/design-system/src/components/colors/Colors.pug'
  'storybook/design-system/src/components/colors/colors.pug'

Person(s) for reviewing proposed changes

@samuel-gomez-axa

Important

Before creating a pull request run unit tests

$ npm test

# watch for changes
$ npm test -- --watch

# For a specific file (e.g., in packages/context/__tests__/command.test.js)
$ npm test -- --watch packages/action

@samuel-gomez-axa
Copy link
Contributor

thank you Xavier, it's probably not passed on my last PR

@xballoy
Copy link
Contributor Author

xballoy commented Oct 1, 2019

How long does "SonarCloud Code Analysis Expected — Waiting for status to be reported " take?

@samuel-gomez-axa
Copy link
Contributor

It's too long, there is a trouble on analysis, @guillaumechervetaxa can you share us the Sonar Link page analysis, please ?

@xballoy
Copy link
Contributor Author

xballoy commented Oct 2, 2019

There is no analysis for this PR: https://sonarcloud.io/dashboard?id=AxaGuilDEv_react-toolkit 🙁

@guillaumechervetaxa guillaumechervetaxa merged commit 66b16d8 into AxaFrance:master Oct 3, 2019
@xballoy xballoy deleted the feat/fix-caseSensitivePaths branch October 3, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants