refactor(react-toolkit-form-summary): migrate to TypeScript #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created my PR against master but I think it would be better to have a branch |
xballoy
commented
Oct 2, 2019
xballoy
commented
Oct 2, 2019
- Bump typescript from 3.2.2 to 3.6.3 - Bump tslint from 5.11.0 to 5.20.0 - Bump tslint-config-prettier from 1.17.0 to 1.18.0 - Remove rules "no-use-before-declare" and "no-unused-variable" because they are deprecated since Typescript 5.9.0.
guillaumechervetaxa
requested changes
Oct 2, 2019
guillaumechervetaxa
approved these changes
Oct 2, 2019
xballoy
changed the title
guillaumechervetaxa
pushed a commit
that referenced
this pull request
Oct 17, 2019
* docs: remove duplicated lines in CONTRIBUTING * refactor: remove unused file * feat(react-toolkit-form-summary): migrate to TypeScript * build: update package-lock.json on several packages * build: bump TypeScript and TSLint - Bump typescript from 3.2.2 to 3.6.3 - Bump tslint from 5.11.0 to 5.20.0 - Bump tslint-config-prettier from 1.17.0 to 1.18.0 - Remove rules "no-use-before-declare" and "no-unused-variable" because they are deprecated since Typescript 5.9.0. * refactor: PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Reference to the issue
#394
Description of the issue
react-toolkit-form-summaryto TypeScript.Person(s) for reviewing proposed changes
@samuel-gomez-axa / @guillaumechervetaxa