Fix/readme #45
Merged
Fix/readme #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,7 +136,8 @@ stories.push({ | |||
|
|
|||
| const storyData = { | |||
| name: 'Form.Input.Checkbox', | |||
| docs:readme, | |||
| docs: readme, | |||
There was a problem hiding this comment.
Why insert readme inside "readme" and "docs"?
There was a problem hiding this comment.
In many components, the readme was included in the docs part.
I did not know if I had to keep together.
So, I insert the readme in both.
There was a problem hiding this comment.
Do you want to remove all readme in docs ?
Or do you want to remove the docs completly ?
There was a problem hiding this comment.
What do you prefer?
I don't like the tabs readme because people don't think to click on it. I prefer to display the readme directly on the main page ^^ (no user effort to do)
There was a problem hiding this comment.
ok i delete readme tab, just keep the docs below the demo.
guillaumechervetaxa
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
No issue, the README of components dont display on addon storybook-readme
Description of the fix
Person(s) for reviewing proposed changes
@guillaumechervetaxa