Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NumberInput): isValidNumber for support zero value in the component numberInput #525

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

Gparquet
Copy link
Contributor

Related issue

Reference to the issue

Here you can add link to related issue

Description of the issue

Your description

Person(s) for reviewing proposed changes

You can add @mention here

Important

Before creating a pull request run unit tests

$ npm test

# watch for changes
$ npm test -- --watch

# For a specific file (e.g., in packages/context/__tests__/command.test.js)
$ npm test -- --watch packages/action

@Gparquet Gparquet changed the title fix: isValidNumber for support zero value in the component numberInput fix(NumberInput): isValidNumber for support zero value in the component numberInput Jan 31, 2020
Copy link
Contributor

@youf-olivier youf-olivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the Unit Test

@Gparquet
Copy link
Contributor Author

@youf-olivier it's ok, i fix this problem

@youf-olivier
Copy link
Contributor

@youf-olivier it's ok, i fix this problem

Great !! Thanks for your PR :)

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@guillaume-chervet
Copy link
Contributor

@youf-olivier tu as mis un truc qui bloque le merge ^^

@youf-olivier
Copy link
Contributor

Oui comme ça je peux valider le change

@mergify mergify bot merged commit a192d20 into master Jan 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/isValidNumber branch January 31, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants