Clean svg icons #538
Merged
Clean svg icons #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome Arnaud :) |
guillaume-chervet
previously approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Good Job Arnaud :)
Have you verify if there isn't breaking change on https://axaguildev.github.io/react-toolkit/latest/design/style/icons/ ?
arnaudforaison
force-pushed
the
clean-svg-icons
branch
from
efcac7f
to
409350b
Compare
youf-olivier
previously approved these changes
Feb 18, 2020
|
La PR est colossal, il ne serait pas possible de la découper en parti |
guillaume-chervet
previously approved these changes
Feb 19, 2020
|
@romuleald La PR semble colossale mais ne l'ai pas vraiment. S'il faut faire autrement pour sync mon fork, je suis preneur |
samuel-gomez-axa
previously approved these changes
Feb 19, 2020
arnaudforaison
dismissed stale reviews from samuel-gomez-axa, guillaume-chervet, and youf-olivier
via
2f4b1a1
arnaudforaison
force-pushed
the
clean-svg-icons
branch
from
409350b
to
2f4b1a1
Compare
arnaudforaison
force-pushed
the
clean-svg-icons
branch
from
2f4b1a1
to
ccbbf06
Compare
youf-olivier
approved these changes
Feb 20, 2020
guillaumechervetaxa
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Some svg icons, sprite included, have attributes deprecated and default color set, that block to override color with custom css style.