Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storybook): delete addon and clean stories #605

Merged
merged 2 commits into from
May 6, 2020
Merged

feat(storybook): delete addon and clean stories #605

merged 2 commits into from
May 6, 2020

Conversation

samuel-gomez-axa
Copy link
Contributor

Related issue

#456 #604

Reference to the issue

bug installation with 'npm run bootstrap'

Description

  • Update storybook
  • delete addon
  • clean all stories
  • add storysource addon
  • add viewport addon
  • add a11y addon

@samuel-gomez-axa samuel-gomez-axa added Type: Bug Something isn't working dependencies Pull requests that update a dependency file Type: Enhancement New feature or request labels May 4, 2020
guillaume-chervet
guillaume-chervet previously approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@guillaume-chervet guillaume-chervet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@youf-olivier
Copy link
Contributor

Ouffff. I'll take some time to read this one :D

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mergify mergify bot merged commit 4de9778 into master May 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/delete-addon-storybook branch May 6, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youf-olivier youf-olivier youf-olivier approved these changes

@guillaumechervetaxa guillaumechervetaxa guillaumechervetaxa approved these changes

@guillaume-chervet guillaume-chervet Awaiting requested review from guillaume-chervet

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Type: Bug Something isn't working Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@samuel-gomez-axa @youf-olivier @guillaumechervetaxa @guillaume-chervet @samuel-gomez