-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-toolkit-table: customize paging labels #608
react-toolkit-table: customize paging labels #608
Conversation
Maybe it's possible to add an i18n module in the future ? 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice !
Should the default value be in French or English? |
ça me parait bien l'anglais par défaut |
Le français est mieu afin de ne pas avoir de breaking change. C'est aussi le français notre cible numéro 1. Arnaud, le toolkit c'est mieu que le toolkit soit légé et ne gére pas le i18n. En tout cas pas dans les composants bas niveau :) |
f550838
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
top
Add customization of labels in
Pager
,Paging
andItems
Pager
previousLabel
,nextLabel
andofLabel
Items
displayLabel
andelementsLabel
Paging
type PagingComponentProps
to inherit ofPager
andItems
props. So it add the following props:previousLabel
,nextLabel
,ofLabel
,displayLabel
,elementsLabel
andmode
Paging
Fixes #563
@guillaume-chervet @samuel-gomez