Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-toolkit-form): add a red star on label of required fields #611

Merged
merged 2 commits into from
May 14, 2020
Merged

feat(react-toolkit-form): add a red star on label of required fields #611

merged 2 commits into from
May 14, 2020

Conversation

xballoy
Copy link
Contributor

@xballoy xballoy commented May 14, 2020

Automatically add a red star on label of required fields.

Sample render (from storybook):
Required field

To migrate from old manual star to new automatic red star:

<TextInput
-  label="My label *"
+  label="My label"
+  classModifier="required"
 {...otherProps}
</TextInput>

cc @guillaume-chervet @samuel-gomez @youf-olivier

@youf-olivier
Copy link
Contributor

Toooooop

Copy link
Contributor

@guillaumechervetaxa guillaumechervetaxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice @xballoy :)

@guillaume-chervet guillaume-chervet merged commit 91a2efc into AxaFrance:master May 14, 2020
@xballoy xballoy deleted the feature/requiredFields branch May 15, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants