build: bump react-select to version 3.1.0 #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No breaking change on the R3 of react-select ? |
|
The breaking changes are:
The last point is the only one that could be a breaking change for us. |
youf-olivier
previously approved these changes
Jun 5, 2020
|
Can you add a Breaking change info in the commit message ? |
BREAKING CHANGE: on removal of all selected values in an isMulti MultiSelect, the value passed to onChange is null and not [].
|
I added a breaking change |
youf-olivier
approved these changes
Jun 5, 2020
guillaumechervetaxa
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump react-select to latest version.
I followed the migration guide.
The only change for us is the new import for the async react-select component.
@guillaume-chervet @samuel-gomez @youf-olivier