Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve lerna integration #641

Merged
merged 4 commits into from
Jul 3, 2020
Merged

ci: improve lerna integration #641

merged 4 commits into from
Jul 3, 2020

Conversation

xballoy
Copy link
Contributor

@xballoy xballoy commented Jun 19, 2020

We work together with @arnaudforaison on this PR. The idea is to improve our integration of lerna.

The packages in the folder examples and storybook are private packages and do not need to be managed by lerna so we removed them and used a file dependency with the toolkit.

To solve the issue with the package-lock.json we simply tell lerna not to generate them.

Fixes #627

@xballoy xballoy changed the title 🚧 ci: improve lerna integration WIP ci: improve lerna integration Jun 19, 2020
xballoy and others added 2 commits June 23, 2020 18:47
- Remove package-lock from packages
- Remove examples and storybook from lerna
@xballoy xballoy changed the title WIP ci: improve lerna integration ci: improve lerna integration Jun 24, 2020
@xballoy xballoy marked this pull request as ready for review June 24, 2020 07:51
@arnaudforaison
Copy link
Contributor

Comme nous avons enlever storybook et design-system de lerna, comment sont déployés ces 2 packages ? Peut avoir une gestion de la version déportée sur lors du déploiement de ces derniers ?

@samuel-gomez-axa
Copy link
Contributor

Les versions des packages sont appliquées lors de la build sur Azure (pour faire la publication), elle s'applique à tous les packages. @guillaumechervetaxa, tu confirmes ?

@guillaumechervetaxa
Copy link
Contributor

@arnaudforaison
Copy link
Contributor

Oui c'est ça avec le npm publish qui fait un lerna publish. Mais comme nous avons enlever les packages private (storybook, styles, design-system et examples), le versionning de ces derniers ne sera plus mis à jour. Avec Xavier on voulait savoir s'il y avait un autre moyen de mettre à jour ? Ou si on ne pouvait pas faire autrement pour ces packages ?

@samuel-gomez-axa
Copy link
Contributor

Et si tu modifies le fichier script publish-docs.js pour mettre à jour leur package.json manuellement ?

@guillaume-chervet
Copy link
Contributor

Il vous suffit de faire pointer le scripts vers le package.json du all

@guillaumechervetaxa
Copy link
Contributor

guillaumechervetaxa commented Jun 24, 2020

et mettre "latest" dans npm version et dans le script refaire npm install, cela fonctionnerais non?

@xballoy
Copy link
Contributor Author

xballoy commented Jun 25, 2020

@samuel-gomez @guillaumechervet @youf-olivier est-ce que vous pouvez tester le local pour valider que cela fonctionne comme attendu ?
Avec Arnaud on a testé sur PC et Mac pour nous ca fonctionne :)

@xballoy
Copy link
Contributor Author

xballoy commented Jun 29, 2020

Up :)

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@youf-olivier
Copy link
Contributor

youf-olivier commented Jun 29, 2020

Je comprend pas tous les tenants et aboutissants de la PR du coup je laisse Sam et guillaume valider (surtout pour cette histoire de version et de publication)

Par contre l'install marche au poil :)

Copy link
Contributor

@samuel-gomez-axa samuel-gomez-axa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super boulot les gars :)

@guillaume-chervet
Copy link
Contributor

I have still that problem on window from your branch

image

Do you have an idea?

@arnaudforaison
Copy link
Contributor

arnaudforaison commented Jul 2, 2020

@guillaume-chervet This problem is due to your node version. For now, toolkit only accept node < 12, this is cause by gulp version.
Downgrade your node version, and I think all must be normal again.

@xballoy
Copy link
Contributor Author

xballoy commented Jul 2, 2020

@guillaume-chervet as I said in #621 it's related to gulp. I think that @samuel-gomez is working on removing it.

@samuel-gomez-axa
Copy link
Contributor

I'm soon finished, for now you can use nvm to get into node 10

Copy link
Contributor

@guillaume-chervet guillaume-chervet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome :)

@youf-olivier youf-olivier merged commit 4240528 into master Jul 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/lerna branch July 3, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travail sur les packages-lock
7 participants