Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(form-input-radio) send id on change #648

Merged
merged 1 commit into from
Jul 7, 2020
Merged

feat(form-input-radio) send id on change #648

merged 1 commit into from
Jul 7, 2020

Conversation

xballoy
Copy link
Contributor

@xballoy xballoy commented Jun 30, 2020

Send the id of the radio button on change.

Fixes #633

@xballoy xballoy changed the title feat(form-input-radio) send ID on change feat(form-input-radio) send id on change Jun 30, 2020
@xballoy xballoy requested review from guillaumechervetaxa and removed request for guillaumechervetaxa July 3, 2020 07:40
@xballoy
Copy link
Contributor Author

xballoy commented Jul 3, 2020

cc @youf-olivier @samuel-gomez @guillaumechervet

@xballoy xballoy force-pushed the feature/633_onChangeRadio branch from d86c273 to 309cf89 Compare July 3, 2020 07:46
youf-olivier
youf-olivier previously approved these changes Jul 3, 2020
View reviewed changes
@xballoy xballoy force-pushed the feature/633_onChangeRadio branch from 309cf89 to 9b1e762 Compare July 6, 2020 11:14
@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mergify mergify bot merged commit 37d3e47 into master Jul 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/633_onChangeRadio branch July 7, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romuleald romuleald romuleald left review comments

@youf-olivier youf-olivier youf-olivier approved these changes

@guillaume-chervet guillaume-chervet guillaume-chervet approved these changes

@samuel-gomez-axa samuel-gomez-axa Awaiting requested review from samuel-gomez-axa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug RadioInput id is always "" on onChange callbacl
5 participants
@xballoy @romuleald @youf-olivier @samuel-gomez-axa @guillaume-chervet