-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): delete gulp v3 and replace by scripts tasks #651
Conversation
Can we fix this warning when we run
|
@xballoy , i fixed the postcss warning an the browserlist warning. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -15,6 +15,7 @@ $border-radius-width: 3px; | |||
top: 0.7rem; | |||
color: $color-dusty-gray; | |||
z-index: 2; | |||
width: 17px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pourquoi des width en px ? Suppression de gulp ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oui, c'est surtout le fait d'avoir supprimer les tasks pour la génération des font icons. J'ai anticipé le CSS qui permettra d'avoir des composants React SVG pour l'utilisation des icons avec le toolkit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tout en faisant attention de ne pas avoir de breaking change avec ceux qui utilisent les font icons ;)
#621 : All builded css for packages are generated by Gulp tasks but the version of Gulp is not compatible with node 12
Person(s) for reviewing proposed changes : @guillaumechervetaxa
Solution : replace all tasks with vanilla scripts and remove Gulp v3
I also deleted several tasks :
(1) Theses tasks generated the icon font files and the sprite for icons.
but i would like to create icons React Components instead in next PR.
So i copy theses generates files in legacy directory sources and just copy it in /dist for non breaking changes
The Design System Website has already updated like SVG React components .
Finally, i deleted the storybook/styles because its unused.