Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): delete gulp v3 and replace by scripts tasks #651

Merged
merged 11 commits into from
Jul 6, 2020

Conversation

samuel-gomez-axa
Copy link
Contributor

#621 : All builded css for packages are generated by Gulp tasks but the version of Gulp is not compatible with node 12

Person(s) for reviewing proposed changes : @guillaumechervetaxa

Solution : replace all tasks with vanilla scripts and remove Gulp v3

  • delete gulpfile.js
  • delete Gulp tasks from ./scripts/tasks/*
  • create style.js in ./scripts that replace all gulp tasks
  • create clean.js in ./scripts for clean all ./dist packages

I also deleted several tasks :

  • bootstrap-theme (boostrap bundle)
  • split-bootstrap-component-universes (splitted bootstrap components themed by universes)
  • split-bootstrap-component (splitted bootstrap components)
  • universe-bundle (generate af-toolkit-core themed by universes)
  • svgstore (generation of svg sprite with icons) (1)
  • iconfont (generation of icon font glyphicon) (1)
  • clean (delete all /dist packages)
  • cleanlock (delete package-lock)
  • generatelock (generate package-lock)

(1) Theses tasks generated the icon font files and the sprite for icons.
image
but i would like to create icons React Components instead in next PR.
So i copy theses generates files in legacy directory sources and just copy it in /dist for non breaking changes
image

The Design System Website has already updated like SVG React components .

Finally, i deleted the storybook/styles because its unused.

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@xballoy
Copy link
Contributor

xballoy commented Jul 3, 2020

Can we fix this warning when we run style.js:

Build style packages   Starting 
Without `from` option PostCSS could generate wrong source map and will not find Browserslist config. Set it to CSS file path or to `undefined` to prevent this warning.
Build style packages   Finished 

package.json Show resolved Hide resolved
@samuel-gomez-axa
Copy link
Contributor Author

samuel-gomez-axa commented Jul 6, 2020

@xballoy , i fixed the postcss warning an the browserlist warning.

@samuel-gomez-axa samuel-gomez-axa added Type: Bug Something isn't working Type: Enhancement New feature or request labels Jul 6, 2020
@samuel-gomez-axa samuel-gomez-axa self-assigned this Jul 6, 2020
@samuel-gomez-axa samuel-gomez-axa linked an issue Jul 6, 2020 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@xballoy xballoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -15,6 +15,7 @@ $border-radius-width: 3px;
top: 0.7rem;
color: $color-dusty-gray;
z-index: 2;
width: 17px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi des width en px ? Suppression de gulp ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oui, c'est surtout le fait d'avoir supprimer les tasks pour la génération des font icons. J'ai anticipé le CSS qui permettra d'avoir des composants React SVG pour l'utilisation des icons avec le toolkit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tout en faisant attention de ne pas avoir de breaking change avec ceux qui utilisent les font icons ;)

@mergify mergify bot merged commit b04cf0c into master Jul 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/delete-gulp-v3 branch July 6, 2020 10:33
@gcruchon gcruchon mentioned this pull request Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

style website make lerna bootstrap crash on windows
4 participants