-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(table-pager): add flexible width when active page number is large #694
fix(table-pager): add flexible width when active page number is large #694
Conversation
558bf5d
to
c7dc725
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c7dc725
to
0591caf
Compare
Hmmmm I rebased after @samuel-gomez merged PR and lost your approval, @arnaudforaison. Sorry. |
Le rebase était vraiment obligatoire ? |
That's my religion, @youf-olivier, I always rebase before submitting a PR. To me:
|
De mémoire ca change rien, le merge se débrouille tout seul, mais t'as surement raison. |
Anyway, it's your move to merge it now, I don't have the write-access on this repo :) |
Related issue
Reference to the issue
#689
Description of the issue
When the table had 4-digit number of pages, the active page was truncated and blue bullet not centered
Person(s) for reviewing proposed changes
@samuel-gomez @guillaumechervet @youf-olivier @LeGrandKhan