Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(new-ds): fix broken link to template pugs #696

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

gcruchon
Copy link
Contributor

@gcruchon gcruchon commented Oct 6, 2020

Related issue

Description of the issue

Can't build the news design system due to broken references to pug templates.

[09:01:00] Plumber found unhandled error:
 Error in plugin "gulp-pug"
Message:
    /Users/a188dt/dev/react-toolkit/storybook/design-system/src/components/demo/demo.pug:5
    3|     -const classDisplayComponent = `${setClass('demo__display', modifier, true)}`
    4|     -const tmplPath = absTmpl !== '' ? absTmpl : tmpl!== '' ? `./src/pages${activePath}/templates/${tmpl}.pug` : ''
  > 5|     -const htmlCode = tmplPath !== '' ? pugg.compileFile(tmplPath, { pretty: true }) : 'No HTML'
    6|     -const sassCode = sassPath !== '' ? fs.readFileSync(`node_modules/@axa-fr/${sassPath}`, 'utf8') : 'No style'
    7|     block
    8|     article(class=classComponent)

ENOENT: no such file or directory, open 'src/pages/style/icons/templates/arrowthin-left.pug'
    at ./src/pages/atoms/button/templates/button-icon.pug line 3
Details:
    errno: -2
    syscall: open
    code: ENOENT
    path: /Users/a188dt/dev/react-toolkit/storybook/design-system/src/components/demo/demo.pug

Person(s) for reviewing proposed changes

@samuel-gomez

Copy link
Contributor

@samuel-gomez-axa samuel-gomez-axa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @gcruchon

@arnaudforaison arnaudforaison merged commit 9081a60 into AxaFrance:master Oct 7, 2020
@gcruchon gcruchon deleted the fix/new-ds branch October 7, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants