chore: implement strict types and PHPStan rules

CHANGELOG.md

@@ -5,6 +5,8 @@
 - feat: Add plugin dependency header.
 - chore: update Composer deps and lint.
 - chore: lock WPBrowser to <3.5.0 to prevent conflicts with Codeception.
+- chore: Implement PHPStan strict rules.
+- chore: Declare `strict_types` in all PHP files.
 - ci: Update GitHub Actions to latest versions.
 - ci: Test plugin compatibility with WordPress 6.5.0.
 - ci: Test plugin compatibility with PHP 8.2.

phpstan.neon.dist

@@ -1,9 +1,24 @@
 parameters:
 		level: 8
+		checkMissingIterableValueType: false # @todo make true
+		checkAlwaysTrueCheckTypeFunctionCall: true
+		checkAlwaysTrueInstanceof: true
+		checkAlwaysTrueStrictComparison: true
+		checkExplicitMixedMissingReturn: true
+		checkFunctionNameCase: true
+		checkInternalClassCaseSensitivity: true
+		checkTooWideReturnTypesInProtectedAndPublicMethods: true
 		inferPrivatePropertyTypeFromConstructor: true
-		checkMissingIterableValueType: false
+		polluteScopeWithAlwaysIterableForeach: false
+		polluteScopeWithLoopInitialAssignments: false
+		reportAlwaysTrueInLastCondition: true
+		reportStaticMethodSignatures: true
+		reportWrongPhpDocTypeInVarTag: true
+		treatPhpDocTypesAsCertain: false
 		featureToggles:
 			disableRuntimeReflectionProvider: true
+		dynamicConstantNames:
+			- WPGRAPHQL_GF_AUTOLOAD
 		stubFiles:
 			# Simulate added properties
 			- phpstan/class-app-context.stub

src/Connection/AbstractConnection.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Connection;
 
 use WPGraphQL\GF\Interfaces\Hookable;

src/Connection/EntriesConnection.php

@@ -8,6 +8,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Connection;
 
 use GraphQL\Error\UserError;

src/Connection/FormFieldsConnection.php

@@ -8,6 +8,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Connection;
 
 use WPGraphQL\GF\Type\Enum\FormFieldTypeEnum;

src/Connection/FormsConnection.php

@@ -7,6 +7,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Connection;
 
 use GraphQL\Type\Definition\ResolveInfo;

src/CoreSchemaFilters.php

@@ -6,6 +6,8 @@
  * @since   0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF;
 
 use WPGraphQL\GF\Data\Factory;

src/Data/Connection/EntriesConnectionResolver.php

@@ -8,6 +8,8 @@
  * @since 0.0.1
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\Connection;
 
 use GFAPI;

src/Data/Connection/FormFieldsConnectionResolver.php

@@ -8,6 +8,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\Connection;
 
 use GraphQL\Type\Definition\ResolveInfo;

src/Data/Connection/FormsConnectionResolver.php

@@ -8,6 +8,8 @@
  * @since 0.0.1
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\Connection;
 
 use GFAPI;

src/Data/EntryObjectMutation.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data;
 
 use Exception;

src/Data/Factory.php

@@ -8,6 +8,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data;
 
 use GraphQL\Deferred;

src/Data/FieldValueInput/AbstractFieldValueInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GF_Field;

src/Data/FieldValueInput/AddressValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 /**
@@ -35,6 +37,8 @@ protected function get_field_name(): string {
 
 	/**
 	 * {@inheritDoc}
+	 *
+	 * @return array
 	 */
 	protected function prepare_value() {
 		$value = $this->args;

src/Data/FieldValueInput/CaptchaValueInput.php

@@ -6,6 +6,8 @@
  * @since 0.11.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GF_Field;

src/Data/FieldValueInput/CheckboxValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GFCommon;
@@ -39,6 +41,7 @@ protected function get_field_name(): string {
 	/**
 	 * {@inheritDoc}
 	 *
+	 * @return array
 	 * @throws \GraphQL\Error\UserError .
 	 */
 	protected function prepare_value() {

src/Data/FieldValueInput/ConsentValueInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GFFormsModel;
@@ -37,6 +39,8 @@ protected function get_field_name(): string {
 
 	/**
 	 * {@inheritDoc}
+	 *
+	 * @return array
 	 */
 	protected function prepare_value() {
 		$field = $this->field;

src/Data/FieldValueInput/EmailValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 /**

src/Data/FieldValueInput/FileUploadValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GraphQL\Error\UserError;
@@ -33,6 +35,8 @@ protected function get_field_name(): string {
 	 * {@inheritDoc}
 	 *
 	 * @throws \GraphQL\Error\UserError
+	 *
+	 * @return string|mixed
 	 */
 	protected function prepare_value() {
 		// Draft entries don't upload files.

src/Data/FieldValueInput/ImageValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GF_Field;
@@ -37,6 +39,8 @@ protected function get_field_name(): string {
 	/**
 	 * {@inheritDoc}
 	 *
+	 * @return array
+	 *
 	 * @throws \GraphQL\Error\UserError
 	 */
 	protected function prepare_value() {

src/Data/FieldValueInput/ListValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GraphQL\Error\UserError;

src/Data/FieldValueInput/NameValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 /**
@@ -35,6 +37,8 @@ protected function get_field_name(): string {
 
 	/**
 	 * {@inheritDoc}
+	 *
+	 * @return array
 	 */
 	protected function prepare_value() {
 		$value = $this->args;

src/Data/FieldValueInput/ProductValueInput.php

@@ -6,6 +6,8 @@
  * @since 0.12.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GFCommon;
@@ -92,6 +94,8 @@ public function get_args() {
 
 	/**
 	 * {@inheritDoc}
+	 *
+	 * @return array
 	 */
 	protected function prepare_value() {
 		$field = $this->field;

src/Data/FieldValueInput/ValueInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 use GFCommon;

src/Data/FieldValueInput/ValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\FieldValueInput;
 
 /**

src/Data/Loader/DraftEntriesLoader.php

@@ -8,6 +8,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\Loader;
 
 use GFFormsModel;
@@ -45,7 +47,7 @@ protected function get_model( $entry, $key ): DraftEntry {
 	 *
 	 * @param array $keys .
 	 *
-	 * @return array|false
+	 * @return array
 	 * @throws \Exception .
 	 */
 	public function loadKeys( array $keys ) {

src/Data/Loader/EntriesLoader.php

@@ -8,6 +8,8 @@
  * @since 0.0.1
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\Loader;
 
 use GFAPI;
@@ -44,7 +46,7 @@ protected function get_model( $entry, $key ): SubmittedEntry {
 	 *
 	 * @param array $keys .
 	 *
-	 * @return array|false
+	 * @return array
 	 * @throws \Exception .
 	 */
 	protected function loadKeys( array $keys ) {

src/Data/Loader/FormsLoader.php

@@ -8,6 +8,8 @@
  * @since 0.0.1
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Data\Loader;
 
 use GFAPI;
@@ -44,7 +46,7 @@ protected function get_model( $entry, $key ): Form {
 	 *
 	 * @param array $keys .
 	 *
-	 * @return array|false
+	 * @return array
 	 * @throws \Exception .
 	 */
 	protected function loadKeys( array $keys ) {

src/Extensions/Extensions.php

@@ -6,6 +6,8 @@
  * @since   0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Extensions;
 
 use WPGraphQL\GF\Extensions\GFChainedSelects\GFChainedSelects;

src/Extensions/GFChainedSelects/Data/FieldValueInput/ChainedSelectValuesInput.php

@@ -6,6 +6,8 @@
  * @since 0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Extensions\GFChainedSelects\Data\FieldValueInput;
 
 use WPGraphQL\GF\Data\FieldValueInput\CheckboxValuesInput;

src/Extensions/GFChainedSelects/GFChainedSelects.php

@@ -6,6 +6,8 @@
  * @since   0.10.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Extensions\GFChainedSelects;
 
 use GF_Field;

src/Extensions/GFChainedSelects/Type/Enum/ChainedSelectFieldAlignmentEnum.php

@@ -6,6 +6,8 @@
  * @since   0.4.0
  */
 
+declare( strict_types = 1 );
+
 namespace WPGraphQL\GF\Extensions\GFChainedSelects\Type\Enum;
 
 use WPGraphQL\GF\Type\Enum\AbstractEnum;