Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement WPGraphQL Coding Standards ruleset (PHPCS) #369

Merged
merged 6 commits into from Jun 7, 2023

Conversation

justlevine
Copy link
Member

@justlevine justlevine commented Jun 4, 2023

What

Updates the PHPCS ruleset to use axepress/wp-graphql-cs and fixes associated sniffs.

Sniffs from the WPGraphQL-Extra ruleset regarding generic array types are currently excluded for a future PR.

Why

https://github.com/AxeWP/WPGraphQL-Coding-Standards#why-use-these-standards

How

Testing Instructions

Additional Info

Checklist:

  • This PR is tested to the best of my abilities.
  • This PR follows the WordPress Coding Standards.
  • This PR has proper inline documentation.
  • This PR has unit tests to verify the code works as intended.
  • The changes in this PR have been noted in CHANGELOG.md

@codeclimate
Copy link

codeclimate bot commented Jun 7, 2023

Code Climate has analyzed commit ebbe29e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 86.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 84.4% (0.0% change).

View more on Code Climate.

@justlevine justlevine merged commit fae94d4 into AxeWP:develop Jun 7, 2023
18 checks passed
@justlevine justlevine deleted the chore/wp-graphql-cs branch June 7, 2023 08:54
@justlevine justlevine mentioned this pull request Jun 7, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant