Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly use filtered form fields when preparing the connection data. #395

Merged
merged 2 commits into from
Feb 4, 2024
Merged

fix: correctly use filtered form fields when preparing the connection data. #395

merged 2 commits into from
Feb 4, 2024

Conversation

justlevine
Copy link
Member

@justlevine justlevine commented Feb 3, 2024 •
edited
Loading

What

This PR fixes the FormFieldConnectionResolver so the form fields filtered by the connection where args are used, instead of the pre-filtered values.

Why

Closes #392

How

Testing Instructions

Additional Info

Checklist:

  • This PR is tested to the best of my abilities.
  • This PR follows the WordPress Coding Standards.
  • This PR has proper inline documentation.
  • This PR has unit tests to verify the code works as intended.
  • The changes in this PR have been noted in CHANGELOG.md

@justlevine justlevine mentioned this pull request Feb 4, 2024
Closed
3 tasks
@justlevine justlevine merged commit 18014a5 into AxeWP:develop Feb 4, 2024
17 of 19 checks passed
@justlevine justlevine deleted the fix/form-fields-page-filter branch February 4, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filtering Query by pageNumber
1 participant
@justlevine