Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long run time to player classifier #690

Closed
drvinceknight opened this issue Aug 10, 2016 · 4 comments
Closed

Add long run time to player classifier #690

drvinceknight opened this issue Aug 10, 2016 · 4 comments
Assignees

Comments

@drvinceknight
Copy link
Member

drvinceknight commented Aug 10, 2016

See chat on #689, idea is to add long_run_time to the classifier dict. We could then change:

long_run_time_strategies = [MetaMajority, MetaMinority, MetaWinner,
                   MetaMajorityMemoryOne, MetaWinnerMemoryOne,
                   MetaMajorityFiniteMemory, MetaWinnerFiniteMemory,
                   MetaMajorityLongMemory, MetaWinnerLongMemory, MetaMixer]

to be

long_run_time_strategies = [s for s in all_strategies if not s.classifier['long_run_time']]

This could be False by default so we'd only need to actually add it to the long_run_time_strategies. All the tests are in place that should pick it up for the lists and we could add a test to the global test player class too...

@marcharper
Copy link
Member

We should define long-run strategies somehow. I suggest we pick one strategy as the threshold, and I nominate PSO Gambler.

drvinceknight added a commit that referenced this issue Aug 11, 2016
drvinceknight added a commit that referenced this issue Aug 11, 2016
drvinceknight added a commit that referenced this issue Aug 11, 2016
@drvinceknight
Copy link
Member Author

Haha: I literally just pushed this using the same classification we had already in place: the meta ones. Easy enough to change though: I'm happy with whatever threshold.

@marcharper
Copy link
Member

That's where it is already.

@drvinceknight
Copy link
Member Author

Ok cool :)

If we wanted to change it, we just need to change this test and then hunt them down: https://github.com/Axelrod-Python/Axelrod/blob/master/axelrod/tests/unit/test_classification.py#L168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants