Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy errors not recognised by travis #868

Closed
drvinceknight opened this issue Feb 18, 2017 · 6 comments
Closed

Mypy errors not recognised by travis #868

drvinceknight opened this issue Feb 18, 2017 · 6 comments

Comments

@drvinceknight
Copy link
Member

drvinceknight commented Feb 18, 2017

#867 and #839 show that travis is passing even if mypy fails. Here is some of the travis output:

axelrod/moran.py:335: error: Argument 1 to "fitness_proportionate_selection" has incompatible type "Tuple[str]"; expected Sequence[int]
axelrod/moran.py:342: error: Cannot determine type of 'players'
axelrod/moran.py:355: error: Need type annotation for variable
axelrod/moran.py:368: error: Cannot determine type of 'players'
axelrod/moran.py:374: error: Incompatible return value type (got Set[Tuple[int, int]], expected "Tuple[str]")
axelrod/moran.py:378: error: Cannot determine type of 'players'
axelrod/moran.py:380: error: Incompatible return value type (got Counter[str], expected "int")
The command "sh ./type_tests.sh" exited with 0.

Not sure what the fix is, but let's keep an eye on travis when merging @marcharper @meatballs (#839 was my fault for not checking this before giving a positive review label).

@drvinceknight
Copy link
Member Author

I'm assuming the relevant part is:

The command "sh ./type_tests.sh" exited with 0.

@drvinceknight
Copy link
Member Author

I wonder if this approach is worth looking at: https://github.com/zulip/zulip/pull/639/files

@drvinceknight
Copy link
Member Author

As noted on #876 Punisher got merged with an error in the type checking. Would be good to get this setup so travis complains properly...

@drvinceknight
Copy link
Member Author

drvinceknight commented Mar 9, 2017

Closed by 878

@drvinceknight
Copy link
Member Author

Woops, closed the wrong thing!

@drvinceknight drvinceknight reopened this Mar 9, 2017
@drvinceknight
Copy link
Member Author

Closed by #878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant