Refactor tests for Prober. #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meatballs
approved these changes
May 24, 2017
marcharper
requested changes
May 25, 2017
| self.first_play_test(C) | ||
| # Always retaliate a defection | ||
| self.responses_test([D], [C] * 2, [C, D]) | ||
| actions = [(C, D)] + [(D, D)] * 10 |
There was a problem hiding this comment.
Is this one equivalent? The original test had a cooperation then a defection by the opponent. If we want to replace the test then one with alternator seems more appropriate.
There was a problem hiding this comment.
Against an Alternator this test becomes stochastic because the strategy randomly defects against a cooperation. The test we're replacing just checked the first defection and not a set of future rounds. I'll change this to use a MockPlayer that starts with C and then D for the remaining rounds.
marcharper
approved these changes
May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #884
Also reformats strategy docstrings (which addresses #225).