Refactor tests for memory one #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meatballs
approved these changes
May 30, 2017
Nikoleta-v3
reviewed
May 31, 2017
docs/reference/bibliography.rst
Outdated
| @@ -33,7 +34,8 @@ documentation. | |||
| for the Iterated Prisoner's Dilemma. Proceedings of the 2015 | |||
| International Conference on Autonomous Agents and Multiagent Systems. | |||
| .. [Nachbar1992] Nachbar J., Evolution in the finitely repeated prisoner’s dilemma, Journal of Economic Behavior & Organization, 19(3): 307-326, 1992. | |||
| .. [Nowak1992] Nowak, M. a., & May, R. M. (1992). Evolutionary games and spatial chaos. Nature. http://doi.org/10.1038/359826a0 | |||
| .. [Nowak1989] Nowak, M., & Sigmund, K. (1989). Natural selection of memory-one strategies for the iterated prisoner's dilemma. Journal of Theoretical biology. http://www.sciencedirect.com/science/article/pii/0096300389900520 | |||
There was a problem hiding this comment.
Thought Nowak was from the first to look at memory one strategies the 1989 article is focused only on the reactive strategies.
I would recommend the following article as a reference for the first study of memory one: https://www.researchgate.net/publication/225248231_Nowak_M_Sigmund_K_The_evolution_of_stochastic_strategies_in_the_Prisoner%27s_Dilemma_Acta_Appl_Math_20_247-265
It can be seen in the appendix that they give full definition of memory one strategies and the transition matrix in a match.
There was a problem hiding this comment.
Thanks @Nikoleta-v3! Fixing now.
Mainly using seeded tests that hit all states (added some tests that were missing as well). Addresses #884
drvinceknight
force-pushed
the
884-testmemoryone
branch
from
146e1ac
to
b170ca1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #884
I also added some references to strategies.