Refactor tests for player. #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meatballs
approved these changes
May 30, 2017
marcharper
requested changes
May 31, 2017
axelrod/player.py
Outdated
| return False | ||
| for _ in range(200): | ||
| try: | ||
| if not next(generator) == next(other_generator): |
There was a problem hiding this comment.
Can we make this != ? If the generator were emitting booleans this could be confusing
There was a problem hiding this comment.
What was the cause of the warning from the prior implementation?
There was a problem hiding this comment.
Good call on !=.
I believe the warning was thrown by an attribute that was not a cycle and ran out of elements. I didn't check through for which one that was though (this change seemed to make sense anyway to me).
This is a minor refactor of some warnings that were occurring: - A `simulate_play` that was using a fake history; - A warning from the generator equality The change to the way the generator equality was being run is based on this error: ```python .........../home/vince/src/Axelrod/axelrod/player.py:165: PendingDeprecationWarning: generator 'Player.__eq__.<locals>.<genexpr>' raised StopIteration for _ in range(200))): ``` Addresses #884
marcharper
approved these changes
Jun 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor refactor of some warnings that were occurring:
simulate_playthat was using a fake history;The change to the way the generator equality was being run is based on
this error:
Addresses #884