Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class is Action in action.py, removed alias Action=Actions #1054

Merged
merged 6 commits into from
Jul 7, 2017

Conversation

eric-s-s
Copy link
Contributor

@eric-s-s eric-s-s commented Jul 6, 2017

#816

please note: I believe I found two minor typos in docs/reference/overview_of_strategies.rst. They have nothing to do with this PR, but I thought they might be worth noting (and are a simple check). I'll mark them.

@@ -536,7 +536,7 @@ elsewhere as HardProber. The strategy starts by playing D, D, C, C on the first
four rounds and then defects forever if the opponent cooperates on rounds
two and three. Otherwise Prober plays as TitForTat would.

*Prober2 came 5th in average score and 6th in wins in S&P's tournament.*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This is a possible minor typo completely unrelated to this PR. It didn't seem worth raising a separate issue. (2 of 2)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a typo to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup.

@@ -392,7 +392,7 @@ earned in the previous round. WSLS is also known as "Win-Stay-Lose-Switch" and
- :math:`P(C\,|\,DC) = 0`
- :math:`P(C\,|\,DD) = 1`

*TF2T came 7th in average score and 13th in wins in S&P's tournament.*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This is a possible minor typo completely unrelated to this PR. It didn't seem worth raising a separate issue. (1 of 2)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

@@ -30,9 +30,9 @@ def meta_strategy(self, value: int) -> None:
By default, treat values like python truth values. Override in child
classes for alternate behaviors."""
if value == 0:
return Actions.D
return Action.D
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with C and D since we've set them above

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeeeeez that's a good catch @marcharper 👍

@@ -536,7 +536,7 @@ elsewhere as HardProber. The strategy starts by playing D, D, C, C on the first
four rounds and then defects forever if the opponent cooperates on rounds
two and three. Otherwise Prober plays as TitForTat would.

*Prober2 came 5th in average score and 6th in wins in S&P's tournament.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a typo to me.

@@ -392,7 +392,7 @@ earned in the previous round. WSLS is also known as "Win-Stay-Lose-Switch" and
- :math:`P(C\,|\,DC) = 0`
- :math:`P(C\,|\,DD) = 1`

*TF2T came 7th in average score and 13th in wins in S&P's tournament.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

Copy link
Member

@drvinceknight drvinceknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for catching the typos.

@marcharper marcharper merged commit bb2a1f8 into Axelrod-Python:master Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants