N tit(s) for M tat(s)

[Chadys]

Resolve #1073 and add the NTitsForMTats asked for in #379

[drvinceknight]

@Chadys looks like a doctest is failing:

File "./docs/tutorials/advanced/classification_of_strategies.rst", line 59, in classification_of_strategies.rst
Failed example:
    len(strategies)
Expected:
    28
Got:
    29

[Chadys]

Yes I saw, NTitsForMTats is a memory one strategy if called with its default arguments, so I updated the returned number of memory one strategies in the example.

[drvinceknight]

Yes I saw, NTitsForMTats is a memory one strategy if called with its default arguments, so I updated the returned number of memory one strategies in the example.

If I'm correct the default is TfT so I'd suggest not including this in axelrod.strategies (which is what I did for ReactivePlayer which doesn't actually have a default) just to avoid having two instances of TfT in there? (So in turn you would revert a49d448)

[Chadys]

I thought all strategies had to be in axelrod.strategies, I changed it !

[drvinceknight]

I thought all strategies had to be in axelrod.strategies,

Not quite :) This is similar to ReactivePlayer and LookerUp which are strategies that are intended to be used to create specific strategies so they're not added to the axelrod.strategies list. (And also the cheating strategies are not in there either.).

I'll review this properly tomorrow, logging off for the evening.

[marcharper]

Can we add one instance to the library as a strategy, with say N=3 M=2 or similar?

[drvinceknight]

Sounds good to me. Perhaps that could be the default?

…

On Tue, 25 Jul 2017, 01:49 Marc Harper, ***@***.***> wrote: Can we add one instance to the library as a strategy, with say N=3 M=2 or similar? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1084 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACCGWrVGvIuib2lcb9EcxlsNWg8c_465ks5sRTuvgaJpZM4OhPd_> .

[drvinceknight]

Two very minor comments from me @Chadys. This looks excellent and good to go otherwise.

Just the other comment from @marcharper about including a default. I see two ways to go:

• Make 3, 2 the default;
• Include a single class 3TitsFor2Tats that's inherited. There are examples of this in the memory_one strategies where we have the generic memory one and LR player as well as a number of defaults.

I don't have a strong feeling either way on this :)

[drvinceknight]

Because of the type hints let's drop the type in the docstrings (in case at some point they are changed and we forget to change them in the docstrings).

[drvinceknight]

PEP8: self.retaliate_count -= 1

[Chadys]

All done, I went with the change in default values solution !

[drvinceknight]

Looks good to me 👍