Remove strategies that were assumed implemented. #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See Axelrod-Python/axelrod-fortran#31 (comment) Not I removed the "Work in progress" also because, similarly, that is being implemented based on the text description in Axelrod's first paper.
meatballs
approved these changes
Jul 27, 2017
|
Some of these, like Joss, were sufficiently described in later sources IIRC. |
Yes but we do not know that, until the actual source code in the Fortran strategies is "figured out" it makes sense to mark these as "not implemented". |
|
So to be super clear: the name of this PR is clumsy, we're not removing the strategies from the library, just tweaking the docs to denote that we don't know that these 3 strategies from Axelrod's second tournament are implemented. (We don't really have a reason to believe that they correspond to the 3 strategies from the first tournament). TLDR: This is just a tweak to documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
Axelrod-Python/axelrod-fortran#31 (comment)
Note I removed the "Work in progress" also because, similarly, that is
being implemented based on the text description in Axelrod's first
paper.