Properly handle recieve_match_attributes for Stalker, simplify for LR Players, and various style fixes #1127
Conversation
…Players, and various style fixes
marcharper
force-pushed
the
match_attributes
branch
from
e5b4b67
to
41f3b6a
Compare
| @@ -62,3 +62,12 @@ def test_strategy(self): | |||
| self.versus_test(opponent=axl.Cooperator(), | |||
| expected_actions=actions, | |||
| match_attributes={"length": 4}) | |||
|
|
|||
| def test_reset(self): | |||
There was a problem hiding this comment.
The parent test_reset_attributes_and_history method also plays against Alternator so I don't believe this is necessary (but it does no harm). Just mentioning it in case there's a reason I'm missing.
There was a problem hiding this comment.
The intent is to catch a regression in the new reset / __init__ methods or the set_match_attributes / receive_match_attributes chain by looking for a specific attribute that should be reset. (There may be other such tests and/or it may be in fact useless.)
There was a problem hiding this comment.
Cool. Thanks. Looks good to me. 👍
There was a problem hiding this comment.
This looks good, just the one comment about one of the tests that I don't believe is necessary (but does no harm - feel free to keep it in).
We should add something to the documentation about using this receive_match_attributes correctly (but that can be done subsequently).
|
(Appveyor is falling over because of some upstream connectivity issues - setting up the conda envs -, as long as one of the builds on it is fine I'm happy.) |
Closes #877