Add test for memory depth #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks that players need at most the memory depth that is described.
This strategy makes use of the cooperation count. It, thus does ont have memory 2.
This ensures it has the correct memory.
It is infinite memory as it defects on last 2 rounds.
Due to reclassification the teams have changed.
marcharper
reviewed
Jan 4, 2018
| @@ -40,7 +40,7 @@ class Geller(Player): | |||
|
|
|||
| name = 'Geller' | |||
| classifier = { | |||
| 'memory_depth': -1, | |||
There was a problem hiding this comment.
FYI: This one I think we did because "it looks into the future" (not suggesting we change it back necessarily).
marcharper
reviewed
Jan 4, 2018
| @@ -22,7 +22,7 @@ class MindReader(Player): | |||
|
|
|||
| name = 'Mind Reader' | |||
| classifier = { | |||
| 'memory_depth': -10, | |||
There was a problem hiding this comment.
Same. I think for these cheating strategies we don't care so much...
There was a problem hiding this comment.
Yeah I thought it was probably due to the "looking in to the future" but taking the notion of infinity to mean "backwards and forwards" I think we're good :) (I agree that we don't care too much :)).
marcharper
approved these changes
Jan 4, 2018
|
Marking this as good to go: whenever you get a chance @meatballs 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This writes a test that verifies that the memory depth given in
player.classifieris an upper bound.It's done using a hypothesis test that only checks a single set of 5 opponents each time so it's not overly expensive (still benefiting from hypothesis's failure database).
This is the commit that writes the test: e9da4f9
Note that it picked up a few mis classifications, that I've fixed here (I'm actually surprised it wasn't more):
DynamicTwoTitsForTat(strategy makes use of the cooperation count, so it's infinite memory)RandomTitForTat: classified correctly, I've just tweaked the implementation.SteinAndRapoport: defects on last two rounds: so it's infinite memory.This closes #1156