Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tricky Level Punisher #1178

Merged
merged 9 commits into from
May 14, 2018
Merged

Add Tricky Level Punisher #1178

merged 9 commits into from
May 14, 2018

Conversation

Nikoleta-v3
Copy link
Member

I picked up #1132 which implements a strategy called Tricky Level Punisher.

The pr was failing due a division by zero error. Moreover, I had to tweak the tests of MetaMajorityLongMemory because now TrickyLevelPunisher is in the strategy's team.

>> import axelrod as axl

>> player = axl.MetaMajorityLongMemory()
>> tricky = axl.TrickyLevelPunisher()
>> tricky in player.team
True

Note that this pr will fail due to #1176, I will rebase once #1177 is merged.

@marcharper
Copy link
Member

Rather than update the meta player tests each time, which amounts to a "change detector test" at the moment and can be a pain to update, we might consider simply having a test for the number of team members.

@Nikoleta-v3
Copy link
Member Author

I am happy to fix the tests for the meta players in a different pr if you all agree.

@drvinceknight
Copy link
Member

Rather than update the meta player tests each time, which amounts to a "change detector test" at the moment and can be a pain to update, we might consider simply having a test for the number of team members.

Yeah great call @marcharper, perhaps not just the number but a test of the makeup of the tea (specific members?) also good to have a test that matches complete too. (@Nikoleta-v3 if you could handle this that'd be great 👍)

#1177 is merged so you should be ok to rebase.

@drvinceknight
Copy link
Member

Thanks @Nikoleta-v3 merging this in 👍

@drvinceknight drvinceknight merged commit 0a7d181 into Axelrod-Python:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants