Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spruce up actions module #1193

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Spruce up actions module #1193

merged 1 commit into from
Aug 15, 2018

Conversation

langner
Copy link
Member

@langner langner commented Aug 15, 2018

  • Improves docstrings and move to numpydoc format
  • Reviewed unit tests and add a few edge cases


C = 1
D = 0
C = 1 # Cooperate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these two inline comments?

Copy link
Member

@drvinceknight drvinceknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @langner 👍

@drvinceknight
Copy link
Member

The CI failure here is due to #1187 which is fixed in #1191 which should be going in soon. :)

@meatballs meatballs merged commit e86dde8 into Axelrod-Python:master Aug 15, 2018
@langner
Copy link
Member Author

langner commented Oct 21, 2018

Note: this was for #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants