Spruce up deterministic_cache #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcharper
reviewed
Aug 17, 2018
axelrod/deterministic_cache.py
Outdated
| cache[key2] = result2 | ||
| ... | ||
| if some_key in cache: | ||
| do_something(cache[some_key] |
marcharper
reviewed
Aug 17, 2018
axelrod/deterministic_cache.py
Outdated
| """Validate a deterministic cache player key. | ||
|
|
||
| The key should always be a 3-tuple, with a pair of axelrod.Player | ||
| instnaces and one integer. Both players should be deterministic. |
marcharper
reviewed
Aug 17, 2018
| @@ -27,6 +28,9 @@ def tearDownClass(cls): | |||
| os.remove(cls.test_save_file) | |||
| os.remove(cls.test_load_file) | |||
|
|
|||
| def setUp(self): | |||
| self.cache = DeterministicCache() | |||
There was a problem hiding this comment.
Does this create a shared cache across all tests? That could cause some confusion.
There was a problem hiding this comment.
I see that the tests all appear logically correct in that self.cache is only used for expected invalid keys, however I think I'd prefer that they each instantiate a new one.
There was a problem hiding this comment.
That's a good point. But since setUp is called before every test method, self.cache is assigned a new, empty cache for each one. Was that your concern?
There was a problem hiding this comment.
Yep, thanks for the explanation.
* Improve docstrings and add module docstring * Move key helper functions to module level * Refactored unit tests to test public API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next bit for #347.
This includes several things:
@staticmethodIMO is best used sparingly.