Update setup.py to include python 3.7 instead of 3.5 #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suspect we've already discussed this and I'm just forgetting but is there a reason why we cannot add 3.7 and keep 3.5? |
|
No reason, just matching with Travis. We "officially" support the two latest released of Python but I don't see any problem leaving 3.5 in. |
meatballs
approved these changes
Sep 4, 2019
|
I can't remember precisely what they were, but there were some things we wanted to do that were only supported in 3.6+ and we decided to leave them until 3.7 came along and we could drop 3.5 |
|
Let's go ahead and merge, if something comes up that needs us to bring 3.5 back in then we can always do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.