Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change EvolvablePlayer serialization to write strings instead of bytes #1267

Merged
merged 2 commits into from
Oct 21, 2019
Merged

Change EvolvablePlayer serialization to write strings instead of bytes #1267

merged 2 commits into from
Oct 21, 2019

Conversation

marcharper
Copy link
Member

for easier inclusion in CSV files (as used in axelrod-dojo).

drvinceknight
drvinceknight requested changes Oct 17, 2019
View reviewed changes
Copy link
Member

@drvinceknight drvinceknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test?

@marcharper
Copy link
Member Author

Done

@drvinceknight drvinceknight merged commit bda5ba5 into master Oct 21, 2019
@marcharper marcharper deleted the improve_serialization branch November 8, 2019 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meatballs meatballs meatballs approved these changes

@drvinceknight drvinceknight drvinceknight approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcharper @meatballs @drvinceknight