Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements a make_use_of function that automatically #1355

Merged
merged 10 commits into from
Jul 9, 2020

Conversation

gaffney2010
Copy link
Member

This resolves #442. The change makes the calculation of the make_use_of classifier easier and less error-prone.

Other changes that are necessary to make this work

  • Adds logic to the Classifiers class to calculate when the key is missing from the class. This should have been there originally.
  • Remove makes_use_of from strategies, so that this will calculate from the function.
  • Edit transformer to check the transformation and the original strategy, when filling out the makes_use_of classifier.
  • Fix tests that had wrong expected makes_use_of.
  • Delete special classifier test on memory one strategies. This is tested by the usual player test suite.

Copy link
Member

@marcharper marcharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@drvinceknight
Copy link
Member

👍

@drvinceknight drvinceknight merged commit 8793e58 into Axelrod-Python:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smarter classification of makes_use_of
3 participants