Fix failing tests rebased for the dev branch #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rategies and added coverage test in test_grudger.py
This was failing on #1364 but the fix is trivial.
drvinceknight
force-pushed
the
fix-failing-tests-from-spitefullCC-for-dev
branch
from
f3ac8eb
to
a3315cd
Compare
marcharper
approved these changes
Sep 9, 2020
Nikoleta-v3
approved these changes
Sep 9, 2020
|
Thanks for merging @Nikoleta-v3, I'll change the default branch to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #1371 on to the
devbranch. After #1367 and #1368 were merged thedevbranch now includes information about the branching strategy in the docs (#1367) and has been formatted with black (#1368).It would be preferable to merge this PR and close #1371. Then we would be able to stop using the
masterbranch and set the default branch todevgoing forward.