Update citations.md #1384
Merged
Update citations.md #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meatballs
approved these changes
Mar 26, 2021
drvinceknight
approved these changes
Mar 26, 2021
|
CI is failing on type checking. We don't pin Suggestion: Change the above (here https://github.com/Axelrod-Python/Axelrod/blob/dev/.github/workflows/config.yml#L48) to: and open an issue to fix/modify at a later date (perhaps it's time for a |
|
It's an unrelated type hint issue due to numpy 1.2.0. |
|
I've opened #1385 that fixes the issues for me locally. |
This fixes the two errors: ``` axelrod/fingerprint.py:444: error: Function "numpy.array" is not valid as a type 22 axelrod/fingerprint.py:444: note: Perhaps you need "Callable[...]" or a callback protocol? 23 Found 1 error in 1 file (checked 1 source file) ``` and: ``` axelrod/strategies/ann.py:125: error: Incompatible types in assignment (expression has type "ndarray", variable has type "List[int]") 34 Found 1 error in 1 file (checked 1 source file) ``` note that in `fingerprint.py` I'm using the `ArrayType` type but that when I tried to use that in `ann.py` a lot of other things broke.
Note we can also remove it from the docs.
No longer necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.